search

covid-alert-ny / covid-green-app

Covid Alert NY - React-Native App
Apache License 2.0
6 stars 1 forks source link

Tab titles should be forced onto two lines regardless of screen width #535

Open mattobee opened 3 years ago

mattobee commented 3 years ago

@ahurworth reports that the tab titles are no longer wrapping on two lines.

Screenshot_20200930-211054

After chatting to @helloantoine, it doesn't sound like the wrapping was actually deliberate. They do have a fixed width in Sketch but that wasn't intended to be implemented in production. We could force them onto two lines regardless of screen width but it may be difficult to do in a way that works for all languages. Will need some investigation.

kevin-sheldon commented 3 years ago

@mattobee do we know the settings or phone screen size that is doing this? I haven't seen this on any device.

mattobee commented 3 years ago

@kevin-sheldon I'm not sure what device @ahurworth was using but I can see the same behaviour on a OnePlus 6 where "My Health Log" fits onto one line. There is nothing forcing them to wrap onto two lines so it will happen on any screen above a certain size/resolution.