covid19-dash / covid-dashboard

Help welcomed if you have expertise in public health web technology, data modeling and munging, or visualization.
https://covid19-dash.github.io/
BSD 3-Clause "New" or "Revised" License
134 stars 41 forks source link

Issue when starting flask #15

Closed glemaitre closed 4 years ago

glemaitre commented 4 years ago

It seems that we introduce a breaking change there:

https://github.com/covid19-dash/covid-dashboard/runs/509621343

We cannot start anymore flask I assume. Any Idea?

ping @GaelVaroquaux @emmanuelle

GaelVaroquaux commented 4 years ago

We think that it is because the server is now more complex, and takes longer to start. @emmanuelle is investigating adding more delay.

glemaitre commented 4 years ago

OK I pushed a commit to add the dependency. Would it be better to start gunicorn instead of the flask testing server or because we don't serve any request it will not be helpful?

emmanuelle commented 4 years ago

Yes gunicorn is what is used usually for example when pushing to heroku

GaelVaroquaux commented 4 years ago

This is fixed.