search

covid19-dash / covid-dashboard

Help welcomed if you have expertise in public health web technology, data modeling and munging, or visualization.
https://covid19-dash.github.io/
BSD 3-Clause "New" or "Revised" License
131 stars 41 forks source link

Add different symbols for different countries, for better visibility #18

Closed emmanuelle closed 4 years ago

emmanuelle commented 4 years ago

https://plot.ly/python/marker-style/#custom-marker-symbols

choose a different cycle length as for colors so that we have a unique (color, symbol) tuple for each country

emmanuelle commented 4 years ago

This corresponds to this part https://github.com/covid19-dash/covid-dashboard/blob/master/make_figures.py#L73 of the code.

ashwinpn commented 4 years ago

Can I work on this??

GaelVaroquaux commented 4 years ago

@ashwinpn yes: this would be great!

ashwinpn commented 4 years ago

Cool, will create a PR as soon as I am done. Has Circle CI been added, as of now?

GaelVaroquaux commented 4 years ago

I'm not sure Circiel CI is working yet (@glemaitre is working on it right now). I'll just checkout your branch and run it locally).

GaelVaroquaux commented 4 years ago

Fixed by #60