search

covid19-dash / covid-dashboard

Help welcomed if you have expertise in public health web technology, data modeling and munging, or visualization.
https://covid19-dash.github.io/
BSD 3-Clause "New" or "Revised" License
131 stars 41 forks source link

Add Circle-CI and storage of the artifacts to be able to review pull requests #21

Closed GaelVaroquaux closed 4 years ago

GaelVaroquaux commented 4 years ago

One challenge is going to be that the dash app hardcode all paths of its components as to the root of the URL ('/assets/styles.css').

Once the CircleCI works, we should use the artifact redirector: https://github.com/marketplace/actions/run-circleci-artifacts-redirector

glemaitre commented 4 years ago

I can take a look at it tomorrow night

glemaitre commented 4 years ago

@GaelVaroquaux Could you give some admin access to the organization level to activate circleci.

GaelVaroquaux commented 4 years ago

@GaelVaroquaux Could you give some admin access to the organization level to activate circleci.

Done!

glemaitre commented 4 years ago

Thanks, I made the first PR to activate de service. I will correct if there are some issues and add the github action to access the artefacts.

GaelVaroquaux commented 4 years ago

Awesome work!!! This is so useful!!