search

covid19-dash / covid-dashboard

Help welcomed if you have expertise in public health web technology, data modeling and munging, or visualization.
https://covid19-dash.github.io/
BSD 3-Clause "New" or "Revised" License
131 stars 41 forks source link

MAINT fix circleci root directory #44

Closed glemaitre closed 4 years ago

glemaitre commented 4 years ago

Cont'd #21

glemaitre commented 4 years ago

OK we need to remove the "/0/" in the URL from the parallel build number.

GaelVaroquaux commented 4 years ago

Current artifacts: https://3-246408325-gh.circle-artifacts.com/0/index.html

Either remove the "/0/" from the artifact URL, or add it to the generated html (not great)

glemaitre commented 4 years ago

I am not finding anywhere in the CircleCI documentation on how to remove this Parallel Number. I think that the fastest way would be to inject the build number even if it is kind of dirty. We could do that only as a post-processing job to publish the artefacts.

GaelVaroquaux commented 4 years ago

We could do that only as a post-processing job to publish the artefacts.

I'm fine with that.

glemaitre commented 4 years ago

I will not be able to finish tonight. Changing the path in the index.html is not enough. We also need "sourceMappingURL" I think by prepending "/0/"