Normalize the time series by the pop of a country

covid19-dash / covid-dashboard

Help welcomed if you have expertise in public health web technology, data modeling and munging, or visualization.

https://covid19-dash.github.io/

BSD 3-Clause "New" or "Revised" License

134 stars 41 forks source link

Normalize the time series by the pop of a country #83

Closed GaelVaroquaux closed 4 years ago

GaelVaroquaux commented 4 years ago

Fixes #8

GaelVaroquaux commented 4 years ago

This is ready for review (for instance looking at the artifacts). cc @poldrack

emmanuelle commented 4 years ago

There seems to be something wrong with the lower bound prediction (consistent across countries)

poldrack commented 4 years ago

looks like the lower bound might be getting doubly logged?

emmanuelle commented 4 years ago

@poldrack click on the "show all checks" link in the "all checks have passed" then on the "details" link in "ci/circleci: python3 artifact — Link to 0/index.html"

poldrack commented 4 years ago

otherwise LGTM!

GaelVaroquaux commented 4 years ago

The lower bound was indeed wrong. I've pushed a fix.

poldrack commented 4 years ago

new version looks good to me!

emmanuelle commented 4 years ago

Merging, thanks!