search

covid19-dash / covid-dashboard

Help welcomed if you have expertise in public health web technology, data modeling and munging, or visualization.
https://covid19-dash.github.io/
BSD 3-Clause "New" or "Revised" License
131 stars 41 forks source link

Display fatalities in dashboard #95

Closed emmanuelle closed 4 years ago

emmanuelle commented 4 years ago

This work has been mostly done by @mrastgoo, and I did some Javascript finishing touches.

It is now possible to toggle between confirmed cases and fatalities thanks to a radio button. Note that we could use a similar approach for log vs linear, which would remove the bug that everything resets to linear when a country is added. It's just a bit involved to code because you have to detect which radio button was clicked.

emmanuelle commented 4 years ago

When merging please don't squash to keep all contributors :-)

emmanuelle commented 4 years ago

Supersedes #94

emmanuelle commented 4 years ago

@poldrack if we merge this do you think we should update the text as well?

poldrack commented 4 years ago

yes, though I think it only needs minor changes - that is, instead of saying "cases" say "cases or fatalities" - LMK know if you want me to do it. in fact I think it would be fine to merge without changes for now and make them later. cheers rp

On Sun, Mar 29, 2020 at 9:48 AM Emmanuelle Gouillart < notifications@github.com> wrote:

@poldrack https://github.com/poldrack if we merge this do you think we should update the text as well?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/covid19-dash/covid-dashboard/pull/95#issuecomment-605665387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUVEE3EIQS6G6GXFK6KJ3RJ53V7ANCNFSM4LWBDG6A .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305

poldrack@stanford.edu http://www.poldracklab.org/

GaelVaroquaux commented 4 years ago

This does not seem significantly slower even on mobile phone.

+1 for merge. After this, if @poldrack can help with reworking the text. I think that it would be important to mention quite high that we are just plotting the data as reported, and not accounting for reporting biases. It is more and more clear that some countries have huge reporting biases in their casualties.

poldrack commented 4 years ago

will do once it's merged

On Sun, Mar 29, 2020 at 12:18 PM Gael Varoquaux notifications@github.com wrote:

This does not seem significantly slower.

+1 for merge. After this, if @poldrack https://github.com/poldrack can help with reworking the text. I think that it would be important to mention quite high that we are just plotting the data as reported, and not accounting for reporting biases. It is more and more clear that some countries have huge reporting biases in their casualties.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/covid19-dash/covid-dashboard/pull/95#issuecomment-605685585, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUVEDQUQYIFXKIKEC76JDRJ6NHNANCNFSM4LWBDG6A .

-- Russell A. Poldrack Albert Ray Lang Professor of Psychology Professor (by courtesy) of Computer Science Bldg. 420, Jordan Hall Stanford University Stanford, CA 94305

poldrack@stanford.edu http://www.poldracklab.org/

GaelVaroquaux commented 4 years ago

Thanks @poldrack!

And thanks @mrastgoo for the contribution.

Merging this one, it has been a long asked for feature.