covid19cz / erouska-android

Fighting against COVID-19 via privacy-first Bluetooth tracing
https://erouska.cz
MIT License
202 stars 55 forks source link

News page refactoring #557

Closed Gh0stahCZ closed 3 years ago

Gh0stahCZ commented 3 years ago

Description

Refactoring logic on the News page.

Screenshots 📸

No UI changes

How Has This Been Tested? 👨‍🔬

Data compared with the previous version and with the production iOS app.

What Has Not Been Tested? 🙅🏻‍♂️

Comparison between data on Android and iOS in DEV envirnment

Checklist ✅

davidvavra commented 3 years ago

@Gh0stahCZ If doing a refactor, I would go for more radical one. Most of the boilerplate is caused by saving each individual number into different SharedPreference key. Everything would be simpler if you persisted it as an object/json.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.