WIP: Make Docker image great again

covid19cz / erouska-webapp

MIT License

12 stars 6 forks source link

WIP: Make Docker image great again #17

Closed Foxlik closed 4 years ago

Foxlik commented 4 years ago

bind to host 0.0.0.0 (for it to work in k8s)
add all packges to the wheel, not just the top
use multistage build to make Dockerfiles neater and image smaller

Kobzol commented 4 years ago

I was just attempting something like this and failed miserably :-) Is there a way to include the packages in setup.cfg with a wildcard? It's pretty brittle to enumerate them by hand.

Btw I'm not sure how the deployment will work, but we should probably use something like

CMD alembic upgrade head \
    && uvicorn --loop uvloop --workers 4 --host 0.0.0.0 --port 5000

and pass the port, DB uri and number of workers via ENV vars when the image is deployed.

Foxlik commented 4 years ago

Right now all I cared about was to get it running in K8s so i can have some sleep. We'll figure out the best way to launch it tomorrow.