covid19datahub / COVID19

A worldwide epidemiological database for COVID-19 at fine-grained spatial resolution
https://covid19datahub.io
GNU General Public License v3.0
251 stars 92 forks source link

admin level numbering, convention is 0=country, 1=first subnational etc. #146

Closed andysouth closed 3 years ago

andysouth commented 3 years ago

Thanks for the great work.

I initially expected your admin levels 1,2,3 to follow the convention that admin0=country, admin1=first subnational etc.
e.g. https://en.wikipedia.org/wiki/List_of_administrative_divisions_by_country

Is there a reason for not following the convention ? Would be clearer to follow the convention if possible or at least provide clearer outline in the readme and documentation to avoid confusion.

eguidotti commented 3 years ago

Hello @andysouth, no there is no particular reason for not following the convention. Since R is 1-index I started with admin area 1 back in March. Now it is too late to change the naming convention as many people are already using it and this may cause troubles for the integrations that are already in place.

The convention is documented on the website here. However I followed your suggestion and updated the README with some more info.

Hope this helps!

andysouth commented 3 years ago

Thanks @eguidotti ! I appreciate the response and the need to not break things for existing users.