search

covid19datahub / COVID19

A worldwide epidemiological database for COVID-19 at fine-grained spatial resolution
https://covid19datahub.io
GNU General Public License v3.0
252 stars 92 forks source link

Added Haiti lev.2 /Colombia lev.2-3 #46

Closed FedericoLG closed 4 years ago

FedericoLG commented 4 years ago

Hello,

I'm pleased to participate in this project, please consider this as a first contribution. Being also the first Github project I work on, and the first R project ever, extended feedback would be welcome on the code and on any other methodological aspects.

I tried to synthetize the code but I am sure it can be improved ( I am pretty sure it would be possible to synthetise the code for columns construction through a function in Col.R).

Currently, the functions work as long as data caching is commented out and "cache" argument is set to false. The only error refers then to "cachedata" being undefined.

Sources

Thanks for the patience in reviewing.

Federico

martinbenes1996 commented 4 years ago

Thank you for your contribution, you made a great work! I just made a review and cleaned the code a bit.

martinbenes1996 commented 4 years ago

There is still a bug. Warning is raised from covid19() on HTI, lvl 2 and COL lvl 2 and 3, maybe needs to be compared with current version of covid19()., the base fork is older.

Because of that bug, fallback (no data error) does not work, NULL is simply returned.

@emanuele-guidotti do not merge yet, review 2 needs to be done.

eguidotti commented 4 years ago

Hello Federico and sorry for the late feedback. The project went under heavy development in the last days...

The code was already nice. I cleaned it a bit and you can find the changes here https://github.com/covid19datahub/COVID19/pull/46/files The code now takes advantage of some of the new function we implemented in the package. See here

We prepared a tutorial with better guidelines and more extensive feedback to help you contribute to the project. See here.

For being your first Github/R project, congrats!

May I just ask you where the data for Haiti population come from? So I'll add to the data sources. Many thanks!

FedericoLG commented 4 years ago

Hello Emanuele, Thank you very much to you and Martin for the feedback and the new resources, no better way to learn. I'll go through the new materials and search for new data. As for Haiti's population data, it was added through Martin's review.

I stay available, good luck with this project!

eguidotti commented 4 years ago

Glad to hear that :)

Martin, can you please post the source for Haiti's population? Thanks!

martinbenes1996 commented 4 years ago

Source for Haiti population: https://en.wikipedia.org/wiki/Departments_of_Haiti

But now when I look at it, I swapped populations of Sud-Est and Sud.

sim55649 commented 4 years ago

Source for Haiti population: https://en.wikipedia.org/wiki/Departments_of_Haiti

But now when I look at it, I swapped populations of Sud-Est and Sud.

ok i will fix it in the next commit together with the longitude and latitude data. thanks

eguidotti commented 4 years ago

Ok great! @FedericoLG I'd need your email address to send you the badge for contributors :) If you don't want to share it publicly here, you can send me a private message on Slack