France 1 2 3 - Githubissues

covid19datahub / COVID19

A worldwide epidemiological database for COVID-19 at fine-grained spatial resolution

https://covid19datahub.io

GNU General Public License v3.0

251 stars 92 forks source link

France 1 2 3 #52

Closed montemurroPaolo closed 4 years ago

eguidotti commented 4 years ago

Thanks! Please check the review. Here my comments:

missing .R extension in file name
make sure you load the COVID package while implementing and testing your function
cache=cache is not a good practice. Don't assign the default argument
please always put the argument cache in first position, all the others are ok in random order
you might want to take advantage of the utilities listed here https://covid19datahub.io/reference/

The number of deaths as of today (12/05/2020) is wrong: 16K instead of 26K. See issue here: https://github.com/opencovid19-fr/data/issues/527