Closed martinbenes1996 closed 4 years ago
Many thanks for your help! I reviewed your pull request. Just a couple of comments:
we are trying to avoid web scraping as far as possible. Would it be possible to contact the data source and understand where they are making the data available? Also the data at regional level would be very interesting. You can link at the project website if you are going to ask them: https://covid19datahub.io
I simplified a bit the data formatting. That's more than enough, everything else is automatically done by the package
Would it be possible for you to fill this file with the data for CZE (line 24)? No R coding required, just update the file with the data and they are automatically merged and made available by the package https://github.com/emanuele-guidotti/COVID19/blob/master/inst/extdata/db/ISO.csv
Thanks!
Just added Swedish Health Agency. You can check it out.
I unintentionally reset commit when trying to remove the "merge commit" and replace with rebase.
Great work! I just cleaned the code a bit.
Please note that the dates are in reverse order in the source data file. Before running cumsum
the dates must be ordered correctly (fixed).
Would you mind (double) checking my review? Then please confirm and I will merge. Thanks again!
I added the region file for Czechia as you asked. The changes seem good, oppnadata() returns tibble for level 2, but data.frame for level 1, is it intended?
I also contacted Czech Ministery of Health and requested direct link to data in regions to avoid webscraping.
Great job! data.frame
or tibble
is fine. I fixed the warning. Thanks for pointing this out.
Your work is now live! Try it out covid19("CZE")
, covid19("SWE")
, covid19("SWE", 2)
Could you please tell me the source for the data you put into the CZE.csv
file? So I can add in the README
Thanks!
Information are combination of Wikipedia and my knowledge. https://cs.wikipedia.org/wiki/%C4%8Cesko#Administrativn%C3%AD_d%C4%9Blen%C3%AD
In English: https://en.wikipedia.org/wiki/Czech_Republic#Administrative_divisions There are only 14 regions so I did it by hand. It is unlikely going to change in following decades. Last change was 1989 - after iron curtain fall.
The inhabitant counts are of course pure estimates, it is probably possible to get some dataset with those numbers to actualize them. The coordinates also come from Wikipedia, I validated them by plotting it in a map - they are centroids of the regions.
On Sun, Apr 19, 2020 at 12:49 PM Emanuele Guidotti notifications@github.com wrote:
Great job! data.frame or tibble is fine. I fixed the warning. Thanks for pointing this out. Your work is now live! Try it out covid19("CZE"), covid19("SWE"), covid19("SWE", 2)
Could you please tell me the source for the data you put into the CZE.csv file? So I can add in the README
Thanks!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/covid19datahub/COVID19/pull/9#issuecomment-616101780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2TWJQ6GWVB4TMYXCNCPS3RNLJMLANCNFSM4MLIPEXA .
-- Kind Regards Bc. Martin Beneš
Information are combination of Wikipedia and my knowledge.
We can't link to your knowledge but Wikipedia is totally fine :) Thanks!
Sources: