covid19datahub / COVID19

A worldwide epidemiological database for COVID-19 at fine-grained spatial resolution
https://covid19datahub.io
GNU General Public License v3.0
251 stars 92 forks source link

Added Czech ministery of health source #9

Closed martinbenes1996 closed 4 years ago

martinbenes1996 commented 4 years ago

Sources:

eguidotti commented 4 years ago

Many thanks for your help! I reviewed your pull request. Just a couple of comments:

Thanks!

martinbenes1996 commented 4 years ago

Just added Swedish Health Agency. You can check it out.

I unintentionally reset commit when trying to remove the "merge commit" and replace with rebase.

eguidotti commented 4 years ago

Great work! I just cleaned the code a bit.

Please note that the dates are in reverse order in the source data file. Before running cumsum the dates must be ordered correctly (fixed).

Would you mind (double) checking my review? Then please confirm and I will merge. Thanks again!

martinbenes1996 commented 4 years ago

I added the region file for Czechia as you asked. The changes seem good, oppnadata() returns tibble for level 2, but data.frame for level 1, is it intended?

I also contacted Czech Ministery of Health and requested direct link to data in regions to avoid webscraping.

eguidotti commented 4 years ago

Great job! data.frame or tibble is fine. I fixed the warning. Thanks for pointing this out. Your work is now live! Try it out covid19("CZE"), covid19("SWE"), covid19("SWE", 2)

Could you please tell me the source for the data you put into the CZE.csv file? So I can add in the README

Thanks!

martinbenes1996 commented 4 years ago

Information are combination of Wikipedia and my knowledge. https://cs.wikipedia.org/wiki/%C4%8Cesko#Administrativn%C3%AD_d%C4%9Blen%C3%AD

In English: https://en.wikipedia.org/wiki/Czech_Republic#Administrative_divisions There are only 14 regions so I did it by hand. It is unlikely going to change in following decades. Last change was 1989 - after iron curtain fall.

The inhabitant counts are of course pure estimates, it is probably possible to get some dataset with those numbers to actualize them. The coordinates also come from Wikipedia, I validated them by plotting it in a map - they are centroids of the regions.

On Sun, Apr 19, 2020 at 12:49 PM Emanuele Guidotti notifications@github.com wrote:

Great job! data.frame or tibble is fine. I fixed the warning. Thanks for pointing this out. Your work is now live! Try it out covid19("CZE"), covid19("SWE"), covid19("SWE", 2)

Could you please tell me the source for the data you put into the CZE.csv file? So I can add in the README

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/covid19datahub/COVID19/pull/9#issuecomment-616101780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2TWJQ6GWVB4TMYXCNCPS3RNLJMLANCNFSM4MLIPEXA .

-- Kind Regards Bc. Martin Beneš

eguidotti commented 4 years ago

Information are combination of Wikipedia and my knowledge.

We can't link to your knowledge but Wikipedia is totally fine :) Thanks!