covid19datahub / COVID19

A worldwide epidemiological database for COVID-19 at fine-grained spatial resolution
https://covid19datahub.io
GNU General Public License v3.0
251 stars 92 forks source link

Add German data source #93

Closed RobertRosca closed 4 years ago

RobertRosca commented 4 years ago

What type of PR is this?

Select all that apply: [ ] -> [x]

R

I confirm:

Additional comments

I'm not an R programmer so this could probably be improved on quite a bit.

Checked the numbers with a few other sources and they seem correct.

One issue is that the ds_check_format function returns an error for levels 2 and 3 saying column 'id' missing. Please add the id for each location (required for level > 1), however none of the other sources I looked at while doing this seem to implement the ID either. What should I do to fix this?

eguidotti commented 4 years ago

Hi @RobertRosca, many thanks for your contribution! I changed the code a little bit, it would be great if you could double check as I cannot speak German unfortunately.

The grouping should happen on IDs and not on names. For example, there are some districts with the same name but in different regions. This is fixed now.

Regarding the message column 'id' missing. Please add the id for each location (required for level > 1) you are right. This is not very clear. I'll improve in the next commit. Thank you.

Just a couple of questions before merging:

Many thanks!

RobertRosca commented 4 years ago

Hi, I've added the latitude and longitude for the regions using this dataset: https://public.opendatasoft.com/explore/dataset/landkreise-in-germany/table/

Looked around a bit but didn't find a source for the population with all the regions in it.

The data is provided by the Robert Koch Institute, and is hosted on an ESRI page.

Hope that helps,

Robert

eguidotti commented 4 years ago

Hi @RobertRosca, thank you for the info! I merged the pull request and added you in the contributors section on the website. Your name will appear in a couple of hours.

I couldn't find your email address to award you the badge for the contribution. If you like to have it, just let me know your email adress here or with a private message on Slack.

Thanks!