search

covid19india / covid19india-react

Tracking the impact of COVID-19 in India
https://www.covid19india.org
MIT License
6.86k stars 3.41k forks source link

Telangana name being rendered incorrectly in resources page. #2442

Closed hemanth-kotagiri closed 3 years ago

hemanth-kotagiri commented 3 years ago

Describe the bug The name of the state Telangana is being rendered as "Telengana" in the resources page.

To Reproduce

  1. Go to 'resources page'
  2. Scroll all the way down
  3. See error

Expected behavior I can see from the project structure that these names, links are being directly fetched from this link : https://api.covid19india.org/crowdsourced_resources_links.json And so, I went to the API repository and I didn't find any file as such. Therefore, fixing the name in that file would do the trick.

The expected behaviour would be to render the name of the state as "Telangana".

Screenshots Below is the screenshot of what I am referring to:

Screenshot from 2021-04-28 12-43-022

Desktop (please complete the following information):

rajputmahesh commented 3 years ago

Yes to fix, changes required at the API side.

Telengana Government Should be "Telangana Government" Independent aggregator - Telengana Should be "Independent aggregator - Telangana"

hemanth-kotagiri commented 3 years ago

@maheshdevelop absolutely. I'll raise one over there as well.

rajputmahesh commented 3 years ago

@maheshdevelop absolutely. I'll raise one over there as well.

Sure, I will check how that could be fix

hemanth-kotagiri commented 3 years ago

@maheshdevelop absolutely. I'll raise one over there as well.

Sure, I will check how that could be fix

AFAIK, we can't fix it. It comes directly from the server and I have also mentioned the route of which the data is available through. And, in the API Repository as well there is no mention of the link I just pasted. If you have found something, or any other way we can fix it, do let me know here first. Thanks!

rajputmahesh commented 3 years ago

@maheshdevelop absolutely. I'll raise one over there as well.

Sure, I will check how that could be fix

AFAIK, we can't fix it. It comes directly from the server and I have also mentioned the route of which the data is available through. And, in the API Repository as well there is no mention of the link I just pasted. If you have found something, or any other way we can fix it, do let me know here first. Thanks!

Well this is the JSON - https://api.covid19india.org/crowdsourced_resources_links.json where changes are required, currently I am not sure where this JSON is, I am configuring API project to understand better

bee-rickey commented 3 years ago

There's nothing to fix on the API. This is directly pulled from a google sheet and the same has been corrected. Thank you for notifying the error.

hemanth-kotagiri commented 3 years ago

@bee-rickey Exactly, as I said. We as contributors couldn't do anything because the data itself is coming from a different private source. Thanks for elaborating more on the issue. Awesome!