A brief description of what changes your PR introduces. The better this description, the quicker we can review, exchange feedback, and merge!
After changing language the placeholder was displaying weird strings and not the cities suggestion you added it was happening because of useCallback function that starts running and do not terminate the priveous instance of useCallback I added language dependency to useCallback and function will terminate whenever the language state changes.
Fixes #2507
✔️ Compiles and passes lint tests
✔️ Properly formatted
✔️ Tested on desktop
✔️ Tested on phone
suryavirkapur
commented
3 years ago
Fixes #2507
A brief description of what changes your PR introduces. The better this description, the quicker we can review, exchange feedback, and merge! After changing language the placeholder was displaying weird strings and not the cities suggestion you added it was happening because of useCallback function that starts running and do not terminate the priveous instance of useCallback I added language dependency to useCallback and function will terminate whenever the language state changes.
Fixes #2507
✔️ Compiles and passes lint tests ✔️ Properly formatted ✔️ Tested on desktop ✔️ Tested on phone
Before Fixing Screenshot :
After Fixing Screenshots