search

covidatlas / coronadatascraper

COVID-19 Coronavirus data scraped from government and curated data sources.
https://coronadatascraper.com
BSD 2-Clause "Simplified" License
363 stars 179 forks source link

Add testing counts to US/MO #1027

Closed davidcardonAH closed 4 years ago

davidcardonAH commented 4 years ago

Summary

Adds testing county-level test counts to Missouri state data

Previously, testing counts were not collected at the county level

This change adds that by pulling from

Changes

jzohrab commented 4 years ago

Hi @davidcardonAH - apologies for the extremely long delay in getting to this PR. I've been working on porting things to our new version of this project, and had quite a few things to keep in the air until that was done. I will move this way up on my list of priorities to port to the new project.

Thanks again, it's disheartening to do good work only to have it languish unused. Sorry about that! Regards, jz

jzohrab commented 4 years ago

I'll change this while porting to Li. The code for submitting the query using the form params is great, thanks.

URL: https://services6.arcgis.com/Bd4MACzvEukoZ9mR/ArcGIS/rest/services/Daily_COVID19_Testing_Report_for_OPI/FeatureServer/0/query

Sample data in the form: image

Note that this result is paginated.

One change I'll make when porting: Li has the concept of "multivalent data", meaning that data from several sources can be pulled into the final reports. So, rather than us going through the gymnastics of shoving the data into the existing us/mo/index.js source, we can create a new source that just gets this data. That will simplify the change. Second, since it's separate, we can actually pull in the full timeseries at once ... we'll have to calculate the running sums, but that should be relatively easy.

There are a lot of changes to the submitted code due to the project changes, but your work provides a great starting point.

jzohrab commented 4 years ago

I've added a new method for arcgis pagination handling in Li, and can soon port the rest of this over to a new source there.

jzohrab commented 4 years ago

I've merged https://github.com/covidatlas/li/pull/385 into Li master, and will deploy it to production shortly. This project isn't merging PRs anymore.

Thanks @davidcardonAH , this was great work that I borrowed/stole to improve the Li code. We now have arcgis pagination with query-style params as you've used here. Cheers! jz