covidatlas / coronadatascraper

COVID-19 Coronavirus data scraped from government and curated data sources.
https://coronadatascraper.com
BSD 2-Clause "Simplified" License
363 stars 179 forks source link

San Francisco renamed its date fields #1052

Closed 1ec5 closed 4 years ago

1ec5 commented 4 years ago

San Francisco renamed its date fields to emphasize that these data points are based on the date of specimen collection rather than the date reported.

Summary

Changes

Additional notes

1ec5 commented 4 years ago

The failures are unrelated to the changes in this PR:

      ✖ Got correct result back from /Users/runner/runners/2.263.0/work/coronadatascraper/coronadatascraper/src/shared/scrapers/BE
      ✖ Got correct result back from /Users/runner/runners/2.263.0/work/coronadatascraper/coronadatascraper/src/shared/scrapers/CH
      ✖ Got correct result back from /Users/runner/runners/2.263.0/work/coronadatascraper/coronadatascraper/src/shared/scrapers/FR
jzohrab commented 4 years ago

Hi @1ec5 - have been away for a few days, and will be away again. I'll take a look at this soon, thanks very much for the PR! jz

jzohrab commented 4 years ago

I pinged @1ec5 on Slack to see if he could port this to Li. Hopefully he says yes :-) and if not, it's backlogged.

jzohrab commented 4 years ago

Thanks @1ec5 , I finally managed to get time to port this to Li. It's in the new code at https://github.com/covidatlas/li/pull/354.

Apologies for the delay!