search

covidatlas / li

Next-generation serverless crawler for COVID-19 data
Apache License 2.0
57 stars 33 forks source link

Fix failing windows ci build #591

Open jzohrab opened 3 years ago

jzohrab commented 3 years ago

Description

None of the project devs use windows, and if we enable windows in github CI things start failing.

The branch revealing the issues is in this repo, in branch fix-windows-ci

(issues uncovered from https://github.com/covidatlas/li/pull/590/files)

If a windows dev can look into these failures, that would be great. Thanks!

jzohrab commented 3 years ago

The very first test fails with a bad filename, it's probably something trivial:

  can crawl Excel

    √ Sandbox Found Architect project manifest, starting up
    Created test cache D:\a\li\li\zz-testing-fake-cache
    Created test report dir D:\a\li\li\zz-reports-dir
    Wrote to local cache: D:\a\li\li\zz-testing-fake-cache\excel-source\2020-08-20\2020-08-20t13_56_36.834z-default-aec8c.xlsx.gz
    Crawl excel-source: 1196.147ms
    √ sanity check.

    × Error: ENOENT: no such file or directory, open 'D:\a\li\li\zz-testing-fake-cache\D:\a\li\li\zz-testing-fake-cache\excel-source\2020-08-20\2020-08-20t13_56_36.834z-default-aec8c.xlsx.gz' (fail at: undefined)

Subsequent tests fail b/c the arc sandbox is listening on that port and isn't shut down correctly.