search

covidpass-org / covidpass

Web app for adding EU Digital COVID Certificates to your wallet apps
https://covidpass.marvinsextro.de
MIT License
1.18k stars 62 forks source link

Generate passes with larger QR codes #3

Closed marvinsxtr closed 3 years ago

marvinsxtr commented 3 years ago

There are different types of pass layouts like boarding pass or coupon which may be more suitable to scan a large QR code

rursache commented 3 years ago

i would treat this as a high priority. the small qr can break the whole idea of keeping it in wallet if it can’t be easily scanned

hauketoenjes commented 3 years ago

Hi,

we are limited by Apple in the QR-Code size. We would love to make it larger, but the best fitting case for our use-case is generic according to the Apple Docs.

Potentially, we could use boardingPass to maybe get a bigger QR-Code on the pass, but that would be the wrong use-case.

rursache commented 3 years ago

well, a simple option on the page could enable boardingPass and let the user decide. not being able to scan the qr code makes the whole wallet thing useless 🤷🏻‍♂️

hauketoenjes commented 3 years ago

Hi, I just tested out a few combinations of QR-Code and pass types and there is no way of making a QR-Code larger on any pass type Apple offers (Boarding Passes, etc.)

The only way of displaying it larger is by using the PKBarcodeFormatAztec format for the QR Code. The problem with this is, that the scanning apps (like CovPassCheck) are not accepting this format. We are forced to use the PKBarcodeFormatQR in order for it to be a valid representation of a vaccination certificate.

So even enabling Boarding Pass generation would not solve this problem. For more information, see the official Apple docs here:

Closing this issue because we are not able to solve it with PassKit.