strings.xml for Spanish

[justinklchan]

1) Make sure all strings throughout the code is merged into strings.xml. 2) Organize strings.xml 3) Translate into Spanish 4) Have an option in the Settings to toggle between the languages

[aakash1313]

@justinklchan Update: All the UI strings are now in strings.xml

[justinklchan]

There's still strings in the Java text for example in TipRecyclerViewAdapter.java which populates the recycler view with various text. You'll probably have to scrub through all the Java code.

[aakash1313]

@justinklchan : yes, next step is that :)

[bananateg]

Hi I am working at this moment, putting values-es

[justinklchan]

Great, thank you @bananateg if you would like other issues to work on, can you email me at jucha@cs.washington.edu? I can add you to our Slack and discuss some bigger features and other things we need help on for this project. Thank you so much for offering your help.

[bananateg]

[bananateg]

I created a local branch. I put only example Language part At image is how show

[aakash1313]

@bananateg : Hey thanks for taking this up, just wanted to make sure that we are following the best practices while working on this:

1. Changing the locale of the app should not change the device locale.
2. Restarting the app after changing the locale is not a good UX and can lead to anomaly in the behavior, please make sure that we don't do that.
3. After changing the locale, make sure everything is aligned as per the locale and tested properly. 4. Please make sure that activity/fragment titles respect the locales too.
4. Please feel free to ping @justinklchan or me if you need any help while working on this.

[justinklchan]

@aakash1313 @bananateg Make the look of this feature adheres to our designs

[bananateg]

Press Language I need to open a dialog for select at language?

[justinklchan]

@bananateg for now just have it as a drop down, we don't need a dialog it looks like @aakash1313 has committed strings.xml for spanish So what we need now is just a drop down that can do the language switching. When you have that, please make a pull request.

[justinklchan]

@aakash1313 I went through every file manually and moved the remaining strings into the XML file. Can you get the remaining strings I've pulled over translated into Spanish? After that mark this issue as closed.

We don't need an option in the settings.

I realized if you change the language in the System Settings of Android, it switches the language automatically, so we don't need this option in our own app.

[aakash1313]

@justinklchan : Awesome, thanks justin, yes that is how localization works if you add more strings to it, it will automatically pick up the device locale and do it for you. Will change the remaining strings and close it today :)

[bananateg]

I finish the change of language, the user only change te language into te app, te language of device no need change,

[bananateg]

I think is better use this and not divide the strings

Hello, %1$s! You have %2$d new messages.

String text = getString(R.string.welcome_messages, username, mailCount);

[aakash1313]

@justinklchan : Added the remaining strings, @bananateg : I agree with you, can you please add that change?

[bananateg]

@aakash1313 yes, i need to create another local branch or is posible that agregate by create the branch remote

[justinklchan]

Whichever is easier for you. We can merge it when you have the code pushed.

[bananateg]

@justinklchan done, how send my code ?

[aakash1313]

@bananateg : Can you create a PR out of it and add @justinklchan as an approver?