Closed ibeckermayer closed 4 years ago
Uses Sass variables for the main colors rather than copying them throughout the various sass files. There are still inline styles which use the hardcoded #*, see (https://github.com/covidwatchorg/portal/issues/372 and https://github.com/covidwatchorg/portal/issues/373)
#*
There was some webpack weirdness going on that I wasn't able to resolve, see the // NOTE:'s I left in the comments.
webpack
// NOTE:
This is branched off of @colbymorrison's PR and so we should wait until that one's merged before merging this one.
Looks good!
colbymorrison
commented
4 years ago colbymorrison
commented
4 years ago
Uses Sass variables for the main colors rather than copying them throughout the various sass files. There are still inline styles which use the hardcoded
#*, see (https://github.com/covidwatchorg/portal/issues/372 and https://github.com/covidwatchorg/portal/issues/373)There was some
webpackweirdness going on that I wasn't able to resolve, see the// NOTE:'s I left in the comments.This is branched off of @colbymorrison's PR and so we should wait until that one's merged before merging this one.