My goal with this was to use a consistent progress-container class as a wrapper for all PendingOperationButtons to create one consistent solution for the loading graphic to not displace other elements vertically when loaded. However I quickly realized that this wouldn't actually work for all cases (like when there are two buttons beside each other and one is a Cancel button that is NOT a <PendingOperationButton> (this happens a lot in the modals).
So I ended up doing a hodge podge of mostly CSS changes here and there to prevent the jerky effect when the loading graphic loads on the page in any context.
Please test thoroughly all buttons and <PendingOperationButton> cases to make sure nothing is clearly messed up. I think I got them all (including the one that loads when a user first sets their password the first time) but good to triple check.
Consistency across modals is still an issue -- the value of doing a modal refactor for consistency is a post-v4 but important refactoring.
Closes #364
My goal with this was to use a consistent
progress-containerclass as a wrapper for allPendingOperationButtonsto create one consistent solution for the loading graphic to not displace other elements vertically when loaded. However I quickly realized that this wouldn't actually work for all cases (like when there are two buttons beside each other and one is a Cancel button that is NOT a<PendingOperationButton>(this happens a lot in the modals).So I ended up doing a hodge podge of mostly CSS changes here and there to prevent the jerky effect when the loading graphic loads on the page in any context.
Please test thoroughly all buttons and
<PendingOperationButton>cases to make sure nothing is clearly messed up. I think I got them all (including the one that loads when a user first sets their password the first time) but good to triple check.Consistency across modals is still an issue -- the value of doing a modal refactor for consistency is a post-v4 but important refactoring.