search

covidwatchorg / portal

Covid Watch Portal web app for diagnosis verification
Apache License 2.0
8 stars 3 forks source link

Reset Password Fix #419

Closed leon-i closed 4 years ago

leon-i commented 4 years ago

Resolves #416

Reset password modal now rejects your new password if it is the same as the inputted current password. Updated onChange function of ResetPasswordModalBase to use a switch statement for better readability/efficiency.

Note: this does not fix issues associated with the "forgot your password" reset via the login page (you are able to use the same password as the previous).

colbymorrison commented 4 years ago

Looking back at Slack, this issue was in regard to the new user case, when we ask new users to change their password on their first login. This uses the same code as the Forgot Password case, both use ChangePasswordModal. I think this PR is still good, but if we merge as is, we should make another issue for those cases.

ibeckermayer commented 4 years ago

Looking back at Slack, this issue was in regard to the new user case, when we ask new users to change their password on their first login. This uses the same code as the Forgot Password case, both use ChangePasswordModal. I think this PR is still good, but if we merge as is, we should make another issue for those cases.

See: https://github.com/covidwatchorg/portal/issues/416#issuecomment-665756640