search

covidwatchorg / portal

Covid Watch Portal web app for diagnosis verification
Apache License 2.0
8 stars 3 forks source link

getVerificationCode testType variable may be vulnerable to sql injection security risk #432

Open whaber opened 4 years ago

whaber commented 4 years ago

We should confirm in cloudfunctions hosted code that all input variables are being checked for validity.

When testType is submitted as confirmed' AND '1'='1' -- message returned with INTERNAL . This was the only security test I found that returned this.

This may because invalid input was detected and rejected by the code (good), or it may be that the code did not validate the input and the text was sent to the data store and it was luck that the attack did not work.

whaber commented 4 years ago

A thought: Is this in the right project?