covidwatchorg / portal

Covid Watch Portal web app for diagnosis verification
Apache License 2.0
8 stars 3 forks source link

Deploy script update for favicon #442

Closed colbymorrison closed 4 years ago

colbymorrison commented 4 years ago

Closes #415

Updates the deploy script to upload the favicon to AWS S3.

Reviewing deploy.sh I realized we're uploading index.html to S3 every push, which isn't necessary as it never changes at this point. And I think we're charged (a very small amount) for each upload. So, deploy.sh now only uploads index.html and favicon.ico to S3 if they were modified in the previous commit. Our usual strategy is to merge a PR into dev/master, so this really checks if index.html and favicon.ico were changed in the previous PR. Needed to update the action workflow to get the last 2 commits instead of the last 1.

As this is a change to the deploy script/workflow, we'll want to watch closely for a PR or 2 to make sure everything still works.