search

covidwatchorg / portal

Covid Watch Portal web app for diagnosis verification
Apache License 2.0
8 stars 3 forks source link

Fix forgot pwd modal on mobile #469

Closed ibeckermayer closed 4 years ago

ibeckermayer commented 4 years ago

closes https://github.com/covidwatchorg/portal/issues/461

ibeckermayer commented 4 years ago

Looks good! Not sure if it's just me - wondering if stylistically you think we should increase the padding a bit on the modals for the mobile site:

image

As seen above, they just seem a bit cramped. This also causes a few problems with the password successfully reset modal, as the clumped elements displace each other a bit and seem a bit off.

image

I agree with you that it still looks a little funky, though I would accept this as "good enough" for now, given the short notice and impending deadline. One thing we still need to sort out is whether we're going to get a professionally designed mobile interface from Vic for v5, or whether we're just going to keep winging it. In the meantime I think our best move is to just get to an acceptable mobile interface and then figure out what improvements we want to make (i.e. your suggestions).

All that said, if you're motivated to tinker around with these, you're free to do so and throw up a PR