search

covidwatchorg / portal

Covid Watch Portal web app for diagnosis verification
Apache License 2.0
8 stars 3 forks source link

No validation message is displayed and code is generated when user is deleting month or date section #489

Closed jcolla-holla closed 4 years ago

jcolla-holla commented 4 years ago

No validation message is displayed and code is generated when user is deleting month or date section.

Asana link here with more details on how to reproduce. If you need access to Asana let me know.

colbymorrison commented 4 years ago

When the user deletes a month or date section, the date is interpreted as an empty string. We allow a code to be generated with just a diagnosis selection and no date, which I think is correct. So for the system, this is the same case (diagnosis selected and no date).

So, if we should leave the date as optional what should the semantics be in this case?