search

covidwatchorg / portal

Covid Watch Portal web app for diagnosis verification
Apache License 2.0
8 stars 3 forks source link

Portal: Wrong IST time is displayed for 12 PM when code is generated around 11-11:50 am IST #509

Closed sync-by-unito[bot] closed 4 years ago

sync-by-unito[bot] commented 4 years ago

Steps:

1.Login into Portal around 11: 10 am IST time 2.Now generate the code and check the message "Share the code ASAP. It will expire in 57 min at 12:15 AM India Standard Time" which is wrong.

Expected: Instead of showing 12:15 AM it should displayed 12:15 PM IST

┆Attachments: Wrong Time FOR 12 PM IST.jpg | Screen Shot 2020-08-16 at 11.23.28 PM.png | image.png

sync-by-unito[bot] commented 4 years ago

➤ Jesse Colligan commented:

PR for this: https://github.com/covidwatchorg/portal/pull/513

sync-by-unito[bot] commented 4 years ago

➤ Basit Husain commented:

I am able to reproduce this issue and moving this out from here !

Re-Opening the same

sync-by-unito[bot] commented 4 years ago

➤ Basit Husain commented:

Please check

sync-by-unito[bot] commented 4 years ago

➤ Isaiah Becker Mayer commented:

@Basit Husain ( https://app.asana.com/0/1188406396263136/list ) I'm unable to reproduce this locally. When I set my clock to 11:xx AM and generate a code, it tells me it will expire at 12:xx PM. Are you sure you're using an up-to-date version of the app? Can you please try a hard-refresh in your browser and try again?

sync-by-unito[bot] commented 4 years ago

➤ Basit Husain commented:

@Isaiah Becker Mayer ( https://app.asana.com/0/1184610905734395/ ) yes I did hard reset and then check this issue, ths y reopened

sync-by-unito[bot] commented 4 years ago

➤ Basit Husain commented:

@Isaiah Becker Mayer ( https://app.asana.com/0/1184610905734395/ ) As you can see in the latest screen shot, it's in incognito mode !

sync-by-unito[bot] commented 4 years ago

➤ Isaiah Becker Mayer commented:

@Basit Husain ( https://app.asana.com/0/1188406396263136/list ) Are you sure your computer's clock isn't confused about AM and PM? I.e. perhaps 11:16 in your screenshot is 11:16 PM according to your computer.

sync-by-unito[bot] commented 4 years ago

➤ Basit Husain commented:

I have verified this issue and now this issue is being fixed and I am marking this issue as "Done"

sync-by-unito[bot] commented 4 years ago

➤ Isaiah Becker Mayer commented:

@Basit Husain ( https://app.asana.com/0/1188406396263136/list ) did you confirm that this was fixed for you?

sync-by-unito[bot] commented 4 years ago

➤ Basit Husain commented:

@Isaiah Becker Mayer ( https://app.asana.com/0/1184610905734395/ ) if you can see my previous comments.. I have verified and closed this issue

Thanks to you