cowbell / cordova-plugin-geofence

Geofencing plugin for cordova
Apache License 2.0
264 stars 318 forks source link

Set Swift version to 2.3 for Xcode 8 compatibility #178

Closed EddyVerbruggen closed 7 years ago

EddyVerbruggen commented 7 years ago

Fixes #174

DipakMahapurkar commented 7 years ago

Hello @EddyVerbruggen, Thanks for your reply, Can u give me some steps for setting Swift version to 2.3 for Xcode 8 compatibility. Thank you

EddyVerbruggen commented 7 years ago

Either of these:

DipakMahapurkar commented 7 years ago

Hey @EddyVerbruggen thanks for your reply, When it will be merged on master branch?. How to use this fork PR in my app?. Thank you.

phyr0s commented 7 years ago

Please merge that

tsubik commented 7 years ago

@EddyVerbruggen looks like this only works when removing and adding this plugin. It doesn't work on clean project platform add command (at least for me). I'm planning to switch from my custom hook to https://github.com/akofman/cordova-plugin-add-swift-support. I have to test it first.

phyr0s commented 7 years ago

@tsubik @EddyVerbruggen Yes is working but only when you remove and add the plugin

tsubik commented 7 years ago

@videmort @EddyVerbruggen I've added the plugin I was talking about 68ca59c, so this PR is not needed anymore. The new approach works when reinstalling plugin as well as on clean platform add.

phyr0s commented 7 years ago

Great!

Buddikazz commented 7 years ago

when build with ios error: 'Geo-Bridging-Header.h' file not found

import "Geo-Bridging-Header.h"

tsubik commented 7 years ago

@Buddikazz you have to reinstall plugin.

Buddikazz commented 7 years ago

yes i remove and reinstall the plugin still the same.

tsubik commented 7 years ago

You can try manually remove Briding-Header file from your xCode project (the one where is the line #import "Geo-Bridging-Header.h"). This file should be now created by additional plugin cordova-plugin-add-swift-support.

Buddikazz commented 7 years ago

Still i'm facing with the issue with manually deleting