KeithHenry commented 11 years ago

I need to use this with jQuery 1.10, and $.browser was deprecated in jQuery 1.9.

Replaced $.browser.msie with /MSIE/.test(navigator.userAgent)

konsumer commented 11 years ago

I think #30 is a better solution.

KeithHenry commented 11 years ago

Ok, browser detection is bad, really you should detect features instead. The reason why is that old browsers may be patched and browsers you've never seen before may have the same issue.

Unfortunately here we're patching for specific buggy behaviour in IE6 & 7 where they can use an iframe to shim history handling - I've no idea how to test for that.

30 is a terrible solution - it replaces $.browser.msie with !$.support.boxModel, which works because the same versions of IE (6 & 7) fail to support display: inline-block - but that's just coincidence. There's no actual relationship between $.support.boxModel and the iframe history hack working.

williamdes commented 4 years ago

Part of https://www.npmjs.com/package/jquery-hashchange/v/1.4.0

cowboy / jquery-hashchange

Replaced $.browser as deprecated in jQuery 1.9 #34

30 is a terrible solution - it replaces $.browser.msie with !$.support.boxModel, which works because the same versions of IE (6 & 7) fail to support display: inline-block - but that's just coincidence. There's no actual relationship between $.support.boxModel and the iframe history hack working.