cowboy / jquery-hashchange

This jQuery plugin enables very basic bookmarkable #hash history via a cross-browser HTML5 window.onhashchange event.

http://benalman.com/projects/jquery-hashchange-plugin/

GNU General Public License v2.0

1.21k stars 258 forks source link

replaced deprecated $.browser.msie with method that doesnt resort to ... #35

Open JimWolff opened 11 years ago

JimWolff commented 11 years ago

...useragent sniffing, ref: http://stackoverflow.com/questions/14892095/browser-msie-error-after-update-to-jquery-1-9-1/14892171#14892171

konsumer commented 11 years ago

I think #30 is a better solution.

JimWolff commented 11 years ago

Definatly a cleaner solution, i just red the other solution was more reliable. After a bit more reading on the subject i found out the snippit was originally taken from a this gist I however also found that conditional comments are not supported in IE 10.

zzgab commented 9 years ago

So, guys, what is the proper pull request in the end, if I want to use a fork that solves this $.browser issue in the best way to your knowledge?

konsumer commented 9 years ago

34 or #36

36 is basically the same solution, but first check for IE is slightly faster for non-IE in #36. Both solve it well.

zzgab commented 9 years ago

Thanks!