search

cowboy / jquery-hashchange

This jQuery plugin enables very basic bookmarkable #hash history via a cross-browser HTML5 window.onhashchange event.
http://benalman.com/projects/jquery-hashchange-plugin/
GNU General Public License v2.0
1.21k stars 258 forks source link

v2.0 and v1.4 #52

Open wdes-bot opened 4 years ago

wdes-bot commented 4 years ago

https://www.npmjs.com/package/jquery-hashchange

wdes-bot commented 4 years ago

Replaces #51

williamdes commented 4 years ago

My bot @wdes-bot holds this PR for @code-lts

anirudhchronus commented 3 years ago

@williamdes what about ie11 support?

williamdes commented 3 years ago

@williamdes what about ie11 support?

Is it not working?

This is too much a long time ago, I forgot about the code of this package

anirudhchronus commented 3 years ago

@williamdes I didnt check it yet, I might be doing it soon. I wanted to confirm it because the 2.0 npm page says it dropped support for IE. I was wondering whether it was Including IE-11 also as many major corporations are still using IE-11. However according to this PR which is very similar to the code change you have done, they only get rid of IE 6/7/8.

williamdes commented 3 years ago

@williamdes I didnt check it yet, I might be doing it soon. I wanted to confirm it because the 2.0 npm page says it dropped support for IE. I was wondering whether it was Including IE-11 also as many major corporations are still using IE-11. However according to this PR which is very similar to the code change you have done, they only get rid of IE 6/7/8.

Yes, 2.0 has no more IE support. But maybe the code still works for your IE version Anyway you can use an older version of the package: https://www.npmjs.com/package/jquery-hashchange