cowboy / jquery-postmessage

jQuery postMessage: Cross-domain scripting goodness
http://benalman.com/projects/jquery-postmessage-plugin/
GNU General Public License v2.0
356 stars 133 forks source link

Remove Opera sniff #4

Open miketaylr opened 13 years ago

miketaylr commented 13 years ago

SUP BEN.

Opera 9.64 is like, 9 versions old. I know Ryan has a fork that normalizes its old document.postMessage implementation--but I think that's going to help like 0.01% of all Opera users. So....this is easier and won't break any sites or provide a crappy fallback for current Opera users.

miketaylr commented 12 years ago

Ben, want me to um write a test for this or something?

miketaylr commented 12 years ago

Beatport.com users can't complete the checkout process because of this sniff now too. :disappointed:

alexmchardy commented 12 years ago

We're patched now at Beatport. Thanks for the fix!

jtsoi commented 12 years ago

I was about to make the same pull request, Opera now supports postMesage.

Ben, are you alive? =)

/JT

chrisdavidmills commented 12 years ago

+1 on this from me too!

alloy-d commented 12 years ago

Yet another +1.

tagawa commented 12 years ago

Another +1 here.

andreasbovens commented 12 years ago

And another +1 from me.

freddywang commented 12 years ago

for Opera, use

window.addEventListener('message', callback, false)

instead of

window.addEventListener('message', callback, !1)

I checked on opera 12, it doesn't work when we pass !1 as third argument of addEventListener method

abhishekdev commented 11 years ago

If not removed this "sniffing" statement should be modified for compatibility with jQuery 1.9.x+ as $.browser is deprecated now.

Calvein commented 11 years ago

:+1:

lukeasrodgers commented 11 years ago

:+1:

damienwhaley commented 11 years ago

Further to this I have modified the browser sniff so that it does not fail on jQuery 1.9.x+ and I have added a note to the README to use the jQuery.browser plugin.

miketaylr commented 7 years ago

hi ben, miss u. ❤️

vladikoff commented 7 years ago

Yesss!

buritica commented 7 years ago

🎂 happy bday PR