cowboy
commented
4 years ago How long is a long time? Also, I'm curious what find is returning, both for the command in the script, and for this:
time find / -type d -exec echo "{}" \; -name 'Plex Media Server' -execdir bash -c 'test -e "{}/Preferences.xml" && pwd >&2' \; -quit | cut -d'/' -f-4 | sort | uniqFor example, this is what I see:
bash-4.3# time find / -type d -name 'Plex Media Server' -execdir test -e "{}/Preferences.xml" \; -print -quit
/volume1/Plex/Library/Application Support/Plex Media Server
real 0m0.125s
user 0m0.053s
sys 0m0.069s
bash-4.3# time find / -type d -exec echo "{}" \; -name 'Plex Media Server' -execdir bash -c 'test -e "{}/Preferences.xml" && pwd >&2' \; -quit | cut -d'/' -f-4 | sort | uniq
/volume1/Plex/Library/Application Support
/
/volume1
/volume1/@appstore
/volume1/@appstore/Docker
/volume1/@appstore/HyperBackup
/volume1/@appstore/MEGAcmd
/volume1/@appstore/Node.js_v12
/volume1/@appstore/Node.js_v8
/volume1/@appstore/Plex Media Server
/volume1/@appstore/SynologyApplicationService
/volume1/@appstore/SynologyDrive
/volume1/@appstore/TextEditor
/volume1/@database
/volume1/@database/pgsql
/volume1/@database/.pgsql.1580215689
/volume1/@database/synolog
/volume1/@database/synologan
/volume1/Plex
/volume1/Plex/@eaDir
/volume1/Plex/Library
/volume1/Plex/tmp_transcoding
/volume1/@S2S
/volume1/@SynoFinder-log
real 0m3.239s
user 0m0.160s
sys 0m0.619s
kstanleyadams
The following step takes a long time to execute
pms_dir="$(find / -type d -name 'Plex Media Server' -execdir test -e "{}/Preferences.xml" \; -print -quit)"One approach to improve this would be to store the value of pms_dir to a file after the first execution, and check this first before trying the full search.
Happy to implement this if you agree with the approach.