search

cowboyd / handlebars.rb

Ruby Bindings for Handlebars.js
http://www.handlebarsjs.com
160 stars 68 forks source link

Support handlebars-source >= 1.1 #26

Closed bradleypriest closed 10 years ago

bradleypriest commented 10 years ago

I looked at upgrading the handlebars-source gem, but the specs all fail.

The handlebars variable here, has no methods on it after upgrade.

Something in the 1.1 release has changed with the handlebars-source, I assume with the change to include AMD and CommonJS builds, but this is out of my depth.

Any ideas?

jimothyGator commented 10 years ago

Was this closed because of the pull request from @acmelwee ? Can we expect that pull request to be accepted soon?

bradleypriest commented 10 years ago

Yep. No need to track the same issue in two issues. No way of knowing when @cowboyd will have some time to review.  — Bradley Priest

On Sat, Jan 25, 2014 at 1:27 AM, Jim Cushing notifications@github.com wrote:

Was this closed because of the pull request from @acmelwee ? Can we expect that pull request to be accepted soon?

Reply to this email directly or view it on GitHub: https://github.com/cowboyd/handlebars.rb/issues/26#issuecomment-33243078