search

cowboysdude / MMM-Astrology

Astrology module for MM2 [NO longer supported... MMM-Astro is the replacement]
8 stars 7 forks source link

no longer working #18

Open sdetweil opened 2 years ago

sdetweil commented 2 years ago

api request returns

{
  "date": "2021-12-22", 
  "horoscope": "[]",    // <- empty
  "sunsign": "cancer"
}
sdetweil commented 2 years ago

also, default for translation_languages is italian, but should default to the local language in config.js also translation fails if the horoscope is empty, as above

pingywon commented 2 years ago

Super broke and no other Horoscope plugins for MM. Disappointing.

Angel-Alvarez6655 commented 2 years ago

Super broke and no other Horoscope plugins for MM. Disappointing.

What you could try, if you liked the designing of the module, find a proper API and make MMM-Astrology.js to point to that new API endpoint. https://ohmanda.com/api/horoscope/leo/ <-- Such as that one. To be honest, the design is good, that's why I showed myself a little ambicious about keeping up this module. I changed some stuffs in the code and got it to work, if you are interested, I can give you the repo or upload my custom version of it. image

sdetweil commented 2 years ago

@Angel-Alvarez6655

fork this repo make changes to a new nanrd branch submit a pull request for consideration

InfinityRed-Code commented 2 years ago

Super broke and no other Horoscope plugins for MM. Disappointing.

What you could try, if you liked the designing of the module, find a proper API and make MMM-Astrology.js to point to that new API endpoint. https://ohmanda.com/api/horoscope/leo/ <-- Such as that one. To be honest, the design is good, that's why I showed myself a little ambicious about keeping up this module. I changed some stuffs in the code and got it to work, if you are interested, I can give you the repo or upload my custom version of it. image

I am a complete noob when it comes to programming and I just cant figure out, why just changing the api url is not working. in the .js file there is no extra processing for the url related to the image from what i could tell, but if I change the url my starsign and icon are not getting displayed properly or rather not getting displayed at all. So I would really apreciate your repo.

pingywon commented 2 years ago

I still would love to see a horoscope module that works! :)

pingywon commented 2 years ago

I still would love to see a horoscope module that works! :)

Well it works fine for me in the widest view. I just dont get the icon and text to the starSign that provides the main "beauty" aspect. Over all I guess most MM Users are running their Systems pervasive and never update them, including the creators of modules. They provide a ton of nice content, so we "dummies" dont have to do it on our own and can play with it. So blaming someone for generously uploading something they personally made is neither nice nor a solution for anything.

Me? Im not sure how you derived that I was blaming anyone for anything. Someone wants to helpful (including you) then this:

@Angel-Alvarez6655

fork this repo make changes to a new nanrd branch submit a pull request for consideration

InfinityRed-Code commented 2 years ago

I still would love to see a horoscope module that works! :)

Well it works fine for me in the widest view. I just dont get the icon and text to the starSign that provides the main "beauty" aspect. Over all I guess most MM Users are running their Systems pervasive and never update them, including the creators of modules. They provide a ton of nice content, so we "dummies" dont have to do it on our own and can play with it. So blaming someone for generously uploading something they personally made is neither nice nor a solution for anything.

Me? Im not sure how you derived that I was blaming anyone for anything. Someone wants to helpful (including you) then this:

@Angel-Alvarez6655 fork this repo make changes to a new nanrd branch submit a pull request for consideration

You are not actively blaming, sorry for the wrong terminology, but it seems quite passive agressive or at least unhelpful and does not add any value to the conversation.

Angel-Alvarez6655 commented 2 years ago

I'm forking this repo as soon as I finish my shift today (4 hrs aprx).

sdetweil commented 2 years ago

@Angel-Alvarez6655 don't need to tell us. anyone can fork at any time, for any reason. all you have to do is push the fork button top right.. easier than posting

pingywon commented 2 years ago

I'm forking this repo as soon as I finish my shift today (4 hrs aprx).

Hey! Done work yet? lol.

Angel-Alvarez6655 commented 2 years ago

Hey! Done work yet? lol.

Sure, give it a try: https://github.com/Angel-Alvarez6655/MMM-Astrology-2

InfinityRed-Code commented 2 years ago

I am very sorry as this github terminology was not familiar to me. The "fork" for me sounded like an synonyme for the f word, but now I know better.

In terms of the new version form @Angel-Alvarez6655 I had to change all the MMM-Astrology module variables in the .js and .css as well as the names of the .js and .css to MMM-Astrology-2 for it to work. Might be a me problem tho. Dont forget to use "MMM-Astrology-2" for the MM config.js aswell.

Also for anyone wanting to use this code and beeing as new and incompetent as me, the fork either just copys everyting from before or he copyed the whole description. So you have to change the git clone command to feature the link in the command above.

sdetweil commented 2 years ago

right the 'fork' makes a copy, but links it to the source.

meaning you can change as much as u want, branching off from the original, aka, fork in the road, or maybe contribute back thru pull requests ( pull your changes back into the source).

if u make big changes, like the module name, then those changes would probably be rejected as a pull request by the source owner.

pingywon commented 2 years ago

I am very sorry as this github terminology was not familiar to me. The "fork" for me sounded like an synonyme for the f word, but now I know better.

In terms of the new version form @Angel-Alvarez6655 I had to change all the MMM-Astrology module variables in the .js and .css as well as the names of the .js and .css to MMM-Astrology-2 for it to work. Might be a me problem tho. Dont forget to use "MMM-Astrology-2" for the MM config.js aswell.

Also for anyone wanting to use this code and beeing as new and incompetent as me, the fork either just copys everyting from before or he copyed the whole description. So you have to change the git clone command to feature the link in the command above.

Who is feeling passive aggressive now?

InfinityRed-Code commented 2 years ago

Thank you for the information @sdetweil .

@pingywon Well my opinion to your messages has not changed at all. As this message: "I still would love to see a horoscope module that works! :)" can't really be looked at in a different way then stated before and even before that you only called the work of @cowboysdude "Super broke" and "Disappointing".

I saw the mistake I made with Angel and apologised. I dont see a mistake in my valuations of your contribution to this conversation so I wont here. Seeing your reaction this is pointless anyways ,so I encourage you to think about it and reflect on why I got this impression in the first place. I wont reply to you again.

pingywon commented 2 years ago

Thank you for the information @sdetweil .

@pingywon Well my opinion to your messages has not changed at all. As this message: "I still would love to see a horoscope module that works! :)" can't really be looked at in a different way then stated before and even before that you only called the work of @cowboysdude "Super broke" and "Disappointing".

I saw the mistake I made with Angel and apologised. I dont see a mistake in my valuations of your contribution to this conversation so I wont here. Seeing your reaction this is pointless anyways ,so I encourage you to think about it and reflect on why I got this impression in the first place. I wont reply to you again.

You sir are a moron. Carry on. I promise I will not reply again.

sdetweil commented 2 years ago

@InfinityRed-Code @pingywon

ok children, knock it off.

we all use words at times that don't represent what we meant, and others take offence.

rule 1, if u can't say anything NICE, don't say ANYTHING. rule 2. if you are upset, go take a walk, come back when u have cooled off.. if that doesn't happen, stay away. rule 3. think about what you say, don't insult the volunteer who gifted what was there..