cowboysysop / charts

Cowboy Sysop Charts
MIT License
121 stars 70 forks source link

Unclear appVersion references in vertical-pod-autoscaler HelmChart Image tags #560

Closed XiaoshiWang closed 1 year ago

XiaoshiWang commented 1 year ago

The image tags specified in the values.yaml were not updated for a long time and now in the current version all with 1.0.0 Example tags:

It is hard to derive if this is really the appVersion of the chart. Maybe they can be just left empty and derived from appVersion in Chart.yaml?

sebastien-prudhomme commented 1 year ago

Renovate is used to update all image versions. The appVersion is just metadata, I really don't want to use that metadata to build image versions. Sometime the tag is not the same and I'm also using images with other versions not directly related to the main app.

sebastien-prudhomme commented 1 year ago

I also try to follow application lifecycle. The product has just been updated from 0.14 to 1.0, I guess it's now considered stable enought.