search

cowboysysop / charts

Cowboy Sysop Charts
MIT License
113 stars 68 forks source link

update: extract command to values.yaml for flowise chart #669

Closed patrickreinan closed 4 weeks ago

patrickreinan commented 1 month ago

Extract "command" to values.yaml for Flowise chart. Update Flowise image to 1.8.1

sebastien-prudhomme commented 1 month ago

Hi @patrickreinan, what is the need to extract command?

patrickreinan commented 1 month ago

Hi @sebastien-prudhomme,

When we are using a custom image sometimes we need to pass extra commands or arguments to run application.

sebastien-prudhomme commented 1 month ago

I will apply the 1.8.1 update in another PR. For the command modification, I need to find a way to apply it to all other charts in this repository. I'm not sure it's a good idea to put the default command in values.yaml, too technical from my point of view.

patrickreinan commented 1 month ago

I got it. Perhaps command could be overridden only if has been set on values, otherwise it would be value set on deployment (as is today).

I think would be better, so the command it would be set only when needed.

What do you think about it?