search

cowdao-grants / cow-fee

GNU General Public License v3.0
2 stars 0 forks source link

Add support for Arbitrum and send summary via slack #27

Closed fleupold closed 3 months ago

fleupold commented 3 months ago

Most changes are coming from cow-sdk version bump in yarn.lock (needed to support Arbirum).

This PR does two things

  1. Address #25
  2. Add support for Arbitrum

Also cleaned up some minor dead code (and made module mandatory, seems too brittle to rely on outdated deployments by defaults)

Testplan

TODO: full local test-run on arbitrum

mfw78 commented 3 months ago

Couldn't we just instead have some infrastructure-specific code that takes stdout as a summary (or otherwise uses stderr for communicating failure, and thus keep infrastructure separate from domain-specific logic?

fleupold commented 3 months ago

We could (in fact it was suggested in the original issue, but didn't receive much traction). My personal feeling is that given this contract is already very tailored to our domain, it's ok to add the slack integration here.

But can change if you fell strongly.

fleupold commented 3 months ago

Was it intentional to redeploy on mainnet and gnosis?

Yes, in order to include the new contracts that support withdrawing the to token