search

cowdao-grants / cow-shed

A gas-efficient, address-bound account abstraction for permissioned hooks on CoW Protocol
GNU General Public License v3.0
8 stars 1 forks source link

nit: relocate constant #10

Closed mfw78 closed 4 months ago

mfw78 commented 5 months ago

https://github.com/meetmangukiya/cow-shed/blob/d67e97dd501d2fec42ab7d3e511bc3f9a2d87a8a/src/COWShedStorage.sol#L2

I'd suggest to relocate this to COWShedProxy.sol. While it is indeed storage related, I think we should keep all the EIP-1967 / proxy handling in one area.

meetmangukiya commented 4 months ago

It is also used in COWShed.sol, both proxy and shed are importing it from storage file