search

cowdao-grants / cow-shed

A gas-efficient, address-bound account abstraction for permissioned hooks on CoW Protocol
GNU General Public License v3.0
8 stars 1 forks source link

EIP712 domain type #7

Closed mfw78 closed 3 months ago

mfw78 commented 3 months ago

Problem

Manually defining the type is superfluous when we're importing solady which includes this.

Line reference: https://github.com/meetmangukiya/cow-shed/blob/d67e97dd501d2fec42ab7d3e511bc3f9a2d87a8a/src/COWShed.sol#L17

Solution

Replace with import from https://github.com/Vectorized/solady/blob/183a5c9cc3ca982492ae5fcca9e7ed6668ddb6ac/src/utils/EIP712.sol

meetmangukiya commented 3 months ago

cannot use it since its a contract, and if you inherit, you also inherit the caching, initializing of immutables, etc and also a public function eip712Domain