search

cowlicks / privacypossum

Privacy Possum makes tracking you less profitable
Other
751 stars 84 forks source link

Breaks Mega.nz even when whitelisted #17

Closed MikeZeDev closed 6 years ago

MikeZeDev commented 6 years ago

Same problem than with vbulletin based forums. Disabling the extension fixed it.

I guess "whitelisting a website" doesnt prevent all modifications by this addon.

ghost commented 6 years ago

I guess "whitelisting a website" doesnt prevent all mofidications by this addon.

Indeed. And that is truly problematic. In these conditions (some sites broken, no whitelist) the extension is not operational at this stage. But it's a work in progress, and I do hope it'll make its way because its scope seems interesting in the are of browsing privacy.

cowlicks commented 6 years ago

Hi @MikeZeDev @mazesy , thank you for your report! I've submitted a fix for the DDG and Qwant breakages. Can you please let me know what other sites are broken? I'd like to fix them.

I fixed the issue that was occurring on mega.nz this morning and made a release. See https://github.com/cowlicks/privacypossum/commit/15db4394af5a79e05b41b750fc23db8aa5b1ac3d

@MikeZeDev What installation of vbulletin was breaking?

@mazesy You are correct about this being a browser wide thing, currently, we inject anti-fingerprinting scripts in every frame. The solution would be to inject them into non-deactivated pages. I have some concerns about race conditions tho. I created a seperate issue for this, see #22.

cowlicks commented 6 years ago

Oh, just to be clear 15db439 makes the fingerprinting detection more robust to errors. The errors are what was breaking websites. It doesn't fix #22.

@MikeZeDev if the vbulletin site is still broken please re-open this issue.