cowlicks / privacypossum

Privacy Possum makes tracking you less profitable
Other
751 stars 84 forks source link

Breaks Reverb.com #91

Open JudasRose opened 6 years ago

JudasRose commented 6 years ago

https://reverb.com. You can not run a search without disabling the extension. Can't click on multiple parts of the website. Firefox 61.0.2. Extension version 2018.7.28. I'd provide the debug log, but I don't really understand the instructions on how to do so.

cowlicks commented 6 years ago

Hi @JudasRose thanks for the report.

The fix for this is pretty simple. I'm working on it now. Here is what's going on if your curious: reverb.com is actually fingerprinting from two scripts https://static.reverb-assets.com/assets/webpack/reverb-66be0290a0d3faab183f.bundle.js https://static.reverb-assets.com/castle/1.0.6/c.js

Both of these come from "static.reverb-assets.com". To Privacy Possum, this origin looks like a third party, but it shouldn't. It is clearly basically a first party to reverb.com, so all we have to do is add reverb-assets.com to the multi-domain first party list.

JudasRose commented 6 years ago

Thanks @cowlicks, but it still seems like it's not 100%. You can do a search now but it doesn't seem to list anything without disabling the extension still. Thanks again.

cowlicks commented 6 years ago

@JudasRose Hi Judas, I actually ran into this while shopping for a banjo. I'm going to reopen this. The problem is actually that Reverb is doing a lot of fingerprinting. Which makes it hard to not-break. Until I can get this fixed, you can disable Privacy Possum for the site (if you haven't already). Here is a gif showing you how: disabe