As a second step from #97 in order to improve contracts inheritability from an external repo, this PR aims to update OZ to the latest version (5.0.2), which brought incompatibilities with repos using this version (as Math rounding enum was modified, for example).
Proposed changes:
run forge update to fetch latest packages (OZ and UniV2)
replaced safeApprove with forceApprove (note: different behaviour)
replaced Math.Rounding.Up/Down for Ceil/Floor
Pending:
[x] testDeploymentRevertsIfApprovalReverts test is failing with a different expectation than written on the test, this must come from the different behaviour that forceApprove has over safeApprove, this test expectation should be fixed before merging
As a second step from #97 in order to improve contracts inheritability from an external repo, this PR aims to update OZ to the latest version (5.0.2), which brought incompatibilities with repos using this version (as Math rounding enum was modified, for example).
Proposed changes:
forge updateto fetch latest packages (OZ and UniV2)safeApprovewithforceApprove(note: different behaviour)Math.Rounding.Up/DownforCeil/FloorPending:
testDeploymentRevertsIfApprovalRevertstest is failing with a different expectation than written on the test, this must come from the different behaviour thatforceApprovehas oversafeApprove, this test expectation should be fixed before merging