cowprotocol / cow-sdk

CoW protocol SDK
https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk
Other
31 stars 9 forks source link

Fix npm dependencies types #119

Closed shoom3301 closed 1 year ago

shoom3301 commented 1 year ago

ethers - should be in "devDependencies" because we need it only for unit-tests @ethersproject/abstract-signer - is used only on types checking level, so, it's ok to have it in "dependencies"

image
github-actions[bot] commented 1 year ago

Coverage Status

Coverage: 69.167%. Remained the same when pulling 17ea8448542d17968292e9b0484b96fbe6d0573c on fix/dependencies into ed068551df5931307e4fe80ed8ff5996e043e109 on main.

socket-security[bot] commented 1 year ago

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: axios@1.3.4, graphql@16.5.0

github-actions[bot] commented 1 year ago

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A

Report generated by eslint-plus-action

shoom3301 commented 1 year ago

@anxolin Thanks for your hawk eye! Deleted axios