search

cowprotocol / cow-sdk

CoW protocol SDK
https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk
Other
31 stars 9 forks source link

fix!: editorial review #125

Closed mfw78 closed 1 year ago

mfw78 commented 1 year ago

This PR:

  1. Has multiple editorial corrections to converge on standardized nomenclature / terminology.
  2. Fixes errors in a code example in README.md.
  3. Fixes a typographical error for exported interface types (reason for breaking change, per semver).
coveralls commented 1 year ago

Coverage Status

coverage: 70.169%. remained the same when pulling ba3c8a350f6a6c8fc185df2a212a1162c0290488 on rndlabs:chore-editorial into 211b98ad879a6eb1c439fa129ce722cababccb9c on cowprotocol:main.

anxolin commented 1 year ago

@mfw78 could you rebase our main branch? we just added a CLA Github Action so you can sign the acceptance of the terms. It's a required step to accept contributions

Thanks again for taking the time!

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mfw78 commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

mfw78 commented 1 year ago

Will recreate pull request and ensure eslint / test.