search

cowprotocol / cow-sdk

CoW protocol SDK
https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk
Other
31 stars 9 forks source link

fix!: editorial review #127

Closed mfw78 closed 1 year ago

mfw78 commented 1 year ago

This PR:

  1. Has multiple editorial corrections to converge on standardized nomenclature / terminology.
  2. Fixes errors in a code example in README.md.
  3. Fixes a typographical error for exported interface types (reason for breaking change, per semver).
github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
:white_check_mark: @mfw78
:x: @anxolin
You can retrigger this bot by commenting recheck in this Pull Request

mfw78 commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

coveralls commented 1 year ago

Coverage Status

coverage: 70.169%. remained the same when pulling 7113fcd40f13774d89fee638bdb825fd1bc096a6 on rndlabs:chore-editorial into 76c79b450bb2d26f42526736c1187fe54c0f2dc4 on cowprotocol:main.

mfw78 commented 1 year ago

@anxolin Can we kindly get another review so this can be merged? I have a moderately large PR forth-coming for merging in ComposableCoW support and want to avoid rebases.