Small nit suggestions - Githubissues

anxolin commented 1 year ago

This is a misc on some NIT suggestions.

Happy to take any of this back, but I feel is still early (we are still doing a RC), and we can arrange things a bit.

I tried to explain the changes in the code, mainly

Rename things around: like BaseConditionalOrder is now ConditionalOrder, and TWAP is Twap
Created a utils.ts with helpers
Created a types.ts with main types
Moved some static methods from the abstract class to the utils.ts
Changed the name of the twap orders type to twap to match what we store onchain in orderClass for the appData

To review

I left some comments in the code too

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request}

coveralls commented 1 year ago

coverage: 81.422% (-0.1%) from 81.541% when pulling a4c398c21f8431469f9f67b9e097def78481525a on small-nit-suggestions into 0aad903e8cb9e85caec57ee7bdae6cfff86e2dbf on main.

anxolin commented 1 year ago

Nice comments!

I will address!

alfetopito commented 1 year ago

@anxolin unit tests also broken here

cowprotocol / cow-sdk

Small nit suggestions #147

To review