search

cowprotocol / cow-sdk

CoW protocol SDK
https://docs.cow.fi/cow-protocol/reference/sdks/cow-sdk
Other
31 stars 9 forks source link

Twap test structure #154

Closed anxolin closed 1 year ago

anxolin commented 1 year ago

This PR just restructures the tests.

In my opinion, tests should assert one thing. This will make it easier to understand the scope, maintain, and know exactly what is wrong when tests start to fail.

For this reason, I reorganized the tests (in anticipation to the fact I want to create a new PR with new tests)

Conditional Order

image

Twap

image

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

coveralls commented 1 year ago

Coverage Status

coverage: 72.617%. remained the same when pulling 0831e0db48ac34f6f80831eaf7aa19739fcf94f7 on twap-test-structure into 3a61922b72cf226eda4adaa085d5129f07715461 on main.

anxolin commented 1 year ago

Addressed the comments and low risk PR (also test pass)

I will merge to not waterfall too much